Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

2371-1 #175

Open
wants to merge 159 commits into
base: master
Choose a base branch
from
Open

2371-1 #175

wants to merge 159 commits into from

Conversation

brutu33
Copy link
Contributor

@brutu33 brutu33 commented Jul 11, 2018

Номер

2371

Номер задания

1

Ссылка на видео с демо

https://drive.google.com/open?id=18S6VGLKAGyYwEiLgUvHFXL2IMC8XHo1Y

Комментарии

Task1 : finish koans and test them with rubocop and reek

end

# rubocop : disable MethodMissingSuper, MissingRespondToMissing
def method_missing(method, *args, &block)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.

@messages = []
end

# rubocop : disable MethodMissingSuper, MissingRespondToMissing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop), MissingRespondToMissing (unknown cop).

def my_private_method
'a secret'
end
# rubocop: disable AccessModifierDeclarations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/UnneededCopDisableDirective: Unnecessary disabling of AccessModifierDeclarations (unknown cop).

# ------------------------------------------------------------------
# rubocop : disable MissingRespondToMissing, MethodMissingSuper
class WellBehavedFooCatcher
def method_missing(method_name, *args, &block)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.

end

# ------------------------------------------------------------------
# rubocop : disable MissingRespondToMissing, MethodMissingSuper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop), MissingRespondToMissing (unknown cop).


class AllMessageCatcher
# rubocop : disable StringLiteralsInInterpolation, MethodMissingSuper, MissingRespondToMissing, UnusedMethodArgument
def method_missing(method_name, *args, &block)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super.

# ------------------------------------------------------------------

class AllMessageCatcher
# rubocop : disable StringLiteralsInInterpolation, MethodMissingSuper, MissingRespondToMissing, UnusedMethodArgument

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/UnneededCopDisableDirective: Unnecessary disabling of MethodMissingSuper (unknown cop).
Lint/UnneededCopDisableDirective: Unnecessary disabling of MissingRespondToMissing (unknown cop).

@taleh007
Copy link
Collaborator

taleh007 commented Jul 11, 2018

@brutu33 тебе необходимо сделать rebase c последним мастером этого репозитория

@brutu33
Copy link
Contributor Author

brutu33 commented Jul 11, 2018

@taleh007 <<тебе необходимо сделать rebase c последним мастером этого репозитория>>

Done

@taleh007
Copy link
Collaborator

@brutu33
найди парней в чате, пускай объяснят и помогут

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.